Add and implement hitsound option #1322
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add feature #759 which will be disabled by default.
This option is located under the Graphics/Sound options and when enabled will play the sound file (if available) "Player hitsound.ogg" when hitting a note successfully (no cb). The sound must be located in the Sounds folder of whatever theme is being used, or fallback.
I have not provided a sound in this pr to be the default etterna hitsound, if this is implemented someone would have to make one, or players will just need to add one themselves.